[POC] Byte size based batching #11952
Draft
+52
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-sili
force-pushed
the
sili-byte-size
branch
from
0e254ff to
8226d1e
Compare
sfc-gh-sili
commented
Dec 18, 2024
| @@ -17,7 +17,7 @@ func newLogs(orig *otlpcollectorlog.ExportLogsServiceRequest) Logs { | |||
| return Logs(internal.NewLogs(orig, &state)) | |||
| } | |||
|
|
|||
| func (ms Logs) getOrig() *otlpcollectorlog.ExportLogsServiceRequest { | |||
| func (ms Logs) GetOrig() *otlpcollectorlog.ExportLogsServiceRequest { | |||
There was a problem hiding this comment.
This will be a change to the API.
sfc-gh-sili
force-pushed
the
sili-byte-size
branch
from
8226d1e to
b89ad4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to tracking issue
Fixes #
Testing
Documentation